Complexity of reallocating storage (was users command crap)

Dan Bernstein brnstnd at kramden.acf.nyu.edu
Thu Feb 7 21:10:34 AEST 1991


In article <2013 at necisa.ho.necisa.oz.au> boyd at necisa.ho.necisa.oz.au (Boyd Roberts) writes:
> Come on Dan, I've told you before.  Check those error conditions.

Boyd, I *am* checking those error conditions. There are a few isolated
sections of code in pty (one being the section Geoff quoted) where
errors that might be handled are ignored. I realize that this 4% of the
code needs to be redone to handle errors better.

How do you think it comes across, Boyd, when a programmer puts a comment
into some code saying ``this needs foo''; someone quotes the code
without the comment; and then you pop in and say ``Come on, I've told
you before. You need foo.''

I think it casts some doubt on your academic standards: you haven't
bothered to read code before you criticize it, even in public.

> Weird things happen.  Just chmod 0 /dev/tty and watch your UNIX
> machine go absolutely ga-ga on you, and _none_ of tools that break
> will say anything of any worth about the problem.

pty: fatal: cannot reopen pty for /dev/tty: Permission denied.

Boyd, fuck off. Or learn to read the code you criticize. Your choice.

---Dan



More information about the Comp.bugs.4bsd.ucb-fixes mailing list