Bug in users command

Dan Bernstein brnstnd at kramden.acf.nyu.edu
Sun Jan 20 03:26:32 AEST 1991


In article <18958 at rpp386.cactus.org> jfh at rpp386.cactus.org (John F Haugh II) writes:
> In article <1126:Jan1811:17:4091 at kramden.acf.nyu.edu> brnstnd at kramden.acf.nyu.edu (Dan Bernstein) writes:
> >second, scmp() appears to take the wrong argument types. Here is a
> Look at the array that is being sorted.  It will be pretty obvious
> once you look at the type of that object that scmp is being called
> properly.

No. Unless I'm mistaken, the objects being passed in are pointers to
arrays of char, while the objects expected are pointers to char. There
is no implicit conversion that justifies this, though undoubtedly it
works on most machines.

> And obviously, since the sort does work, it is being
> called with the correct values.

Obviously there aren't any extra levels of indirection, but that doesn't
make the code right.

Anyway, the 200-user limit is purely silly.

---Dan



More information about the Comp.bugs.4bsd.ucb-fixes mailing list