Help with SLIP

Chris Torek chris at mimsy.UUCP
Sat May 14 15:33:34 AEST 1988


In article <11434 at mimsy.UUCP> I posted some diffs, including the following:
->! /* $Header: if_sl.c,v 1.2 87/09/03 09:47:01 chris Exp $ */

In article <490 at tub.UUCP> cabo at tub.UUCP (Carsten Bormann) writes:
-Nanu! (German word for sudden surprise.)
-When I eyeballed the if_sl.c in the recent comp.bugs.4bsd.ucb-fixes
-distribution a few days ago, I found the following revision string
-(note the same author, the higher revision number and the older date):
-
->/* $Header: if_sl.c,v 1.12 85/12/20 21:54:55 chris Exp $ */

The revision numbers got out of sync when I re-set everything after
converting from 4.3BSD-beta to 4.3BSD-release.  if_sl 1.2 above is a
version with a fix I made shortly after the release.  (My own version
is now 1.5, but none of *those* changes are relevant.)

-and the following bug:
-
->		/*
->		 * If system is getting low on clists
->		 * and we have something running already, stop here.
->		 */
->		if (cfreecount < CLISTRESERVE + SLMTU && tp->t_outq.c_cc == 0)
->			return;

The 1.12 Berkeley version is wrong: obviously `we have something running'
means `tp->t_outq.c_cc != 0'.  The comment is right and the code is wrong
(for once!).  The version I sent to Berkeley was correct; Mike must have
edited it slightly....
-- 
In-Real-Life: Chris Torek, Univ of MD Comp Sci Dept (+1 301 454 7163)
Domain:	chris at mimsy.umd.edu	Path:	uunet!mimsy!chris



More information about the Comp.unix.wizards mailing list